Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected missuse of a variable in the DRY exemple part of SOLID #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Corrected missuse of a variable in the DRY exemple part of SOLID #77

wants to merge 2 commits into from

Conversation

XalbatEcheverria
Copy link

Was using "employees" instead of "employee"

aroranirav2
aroranirav2 reviewed Feb 20, 2020
View reviewed changes
Copy link

@aroranirav2 aroranirav2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I would say it looks good to me.

toanvo288
toanvo288 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@toanvo288 toanvo288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Totally agree.

Chobocharles
Chobocharles approved these changes May 15, 2021
View reviewed changes
Copy link

@Chobocharles Chobocharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aroranirav2 aroranirav2 aroranirav2 left review comments

@dmitryvhf dmitryvhf dmitryvhf approved these changes

@toanvo288 toanvo288 toanvo288 approved these changes

@Chobocharles Chobocharles Chobocharles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XalbatEcheverria @aroranirav2 @Chobocharles @toanvo288 @dmitryvhf