Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload rules configmap #162

Merged
merged 6 commits into from
Mar 5, 2021
Merged

Reload rules configmap #162

merged 6 commits into from
Mar 5, 2021

Conversation

clyang82
Copy link
Contributor

fix this issue - observatorium/operator#19

@clyang82 clyang82 changed the title Reload rules configmap [WIP]Reload rules configmap Oct 30, 2020
@clyang82
Copy link
Contributor Author

clyang82 commented Oct 30, 2020 •
edited
Loading

@squat @metalmatze Please take a look if you agree with this approach to fix the reload configmap issue.

If so, I will add some tests to validate by kubeval. Thanks.

@clyang82 clyang82 changed the title [WIP]Reload rules configmap Reload rules configmap Oct 31, 2020
@clyang82 clyang82 force-pushed the reload_rules branch 2 times, most recently from efa92cc to 0fc96f6 Compare November 2, 2020 10:02
@marcolan018
Copy link
Contributor

marcolan018 commented Nov 9, 2020 •
edited
Loading

@metalmatze
can you help to review this PR?
We know that we need to recreate the PR, but want to check whether the approach is ok before that.
thanks

@kakkoyun kakkoyun requested a review from metalmatze November 12, 2020 09:20
metalmatze
metalmatze reviewed Nov 13, 2020
View reviewed changes
all.jsonnet Outdated Show resolved Hide resolved
jsonnet/kube-thanos/kube-thanos-rule.libsonnet Outdated Show resolved Hide resolved
jsonnet/kube-thanos/kube-thanos-rule.libsonnet Outdated Show resolved Hide resolved
@clyang82 clyang82 requested a review from metalmatze November 15, 2020 03:37
Base automatically changed from master to main March 3, 2021 17:07
simonpasquier
simonpasquier reviewed Mar 4, 2021
View reviewed changes
all.jsonnet Outdated Show resolved Hide resolved
kakkoyun
kakkoyun reviewed Mar 5, 2021
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. If you rebase it we can merge.

@clyang82
rebase
ef2fbe5 
Signed-off-by: clyang82 <[email protected]>
@clyang82
Copy link
Contributor Author

clyang82 commented Mar 5, 2021

@kakkoyun rebased. Thanks.

@clyang82 clyang82 requested a review from kakkoyun March 5, 2021 07:32
kakkoyun
kakkoyun approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@kakkoyun kakkoyun merged commit 95124dd into thanos-io:main Mar 5, 2021
@clyang82 clyang82 deleted the reload_rules branch March 5, 2021 07:40
@clyang82 clyang82 mentioned this pull request Mar 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@kakkoyun kakkoyun kakkoyun approved these changes

@metalmatze metalmatze Awaiting requested review from metalmatze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clyang82 @marcolan018 @kakkoyun @metalmatze @simonpasquier