feat(sidecar): make external labels configurable #7836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badrabubker
force-pushed
the
external-labels
branch
2 times, most recently
from
fa98815
to
f45d7ce
Compare
Allow setting external labels via cmd flags Co-authored-by: Seena Fallah <[email protected]> Signed-off-by: Badreddin Aboubakr <[email protected]>
badrabubker
force-pushed
the
external-labels
branch
from
f45d7ce
to
93ecd1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow setting external labels via cmd flags to support using sidecar with other Prometheus speaking APIs, which do not have config API.