Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receive: Allow specifying a custom gRPC service config via flag #7907

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

philipgough
Copy link
Contributor

@philipgough philipgough commented Nov 14, 2024

receive: Adds a flag to allow specifying custom behaviour for gRPC.

The flag needs to be a JSON string as defined by https://github.com/grpc/grpc/blob/d0a7c33b43d14adafcec9379d40ae09c7ba76bf9/doc/service_config.md

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@philipgough philipgough force-pushed the grpc-conf branch 2 times, most recently from 8979d76 to 281dcad Compare November 14, 2024 17:19
@MichaHoffmann
Copy link
Contributor

Why only for receiver though? Wouldn't all grpc APIs make sense?

@philipgough
Copy link
Contributor Author

Why only for receiver though? Wouldn't all grpc APIs make sense?

Potentially. Probably less of in a need in other components to tweak this but I am happy to add it if there is a perceived benefit. I was trying to tackle the problem discussed here for receive.

I see for example query is using a hardcoded config for endpoint groups

func EndpointGroupGRPCOpts() []grpc.DialOption {

Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!
I'd also want the same flag in other components, as it seems useful to tune @philipgough

@philipgough
Copy link
Contributor Author

I'd also want the same flag in other components, as it seems useful to tune

@saswatamcode ack, do you want them added to this PR?

@saswatamcode
Copy link
Member

Let's do in future PRs

@saswatamcode saswatamcode merged commit 1d76335 into thanos-io:main Nov 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants