Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip TestDistributedEngineWithDisjointTSDBs #7911

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Skip TestDistributedEngineWithDisjointTSDBs #7911

merged 1 commit into from
Nov 15, 2024

Conversation

saswatamcode
Copy link
Member

@saswatamcode saswatamcode commented Nov 15, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

The test documents a bug, so need to skip until bug is fixed cc: @MichaHoffmann
Fixes main

Verification

@saswatamcode
Skip TestDistributedEngineWithDisjointTSDBs
cfb9e57 
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
MichaHoffmann
MichaHoffmann approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@saswatamcode saswatamcode enabled auto-merge (squash) November 15, 2024 10:11
@saswatamcode saswatamcode merged commit 2a975d3 into thanos-io:main Nov 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaHoffmann MichaHoffmann MichaHoffmann approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saswatamcode @MichaHoffmann