-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Toast Notification #69
Conversation
Visit the preview URL for this PR (updated for commit 691190d): https://tcl-75-smart-shopping-list--pr69-wc-toastify-notifica-urvhwya5.web.app (expires Sun, 20 Oct 2024 21:38:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde |
Since we replaced the "alerts" with Toastify, is there a way to set up tests for Toastify? |
Looks really cool, I love this change! Makes such a big difference for the app! I noticed that a confirm window is removed from handleDeleteItem inside ListItem component, so we should add that back |
I noticed that you added back the if block and voted for the custom dialog! Do you think you'd want to create that dialog? Or we can team up, let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed in our sync that it's ok for @warrenchan13 to remove the test portion of this to move forward.
The other option is to add mocks for this library for tests to pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @deeheber said, just need to update the tests to get this baby merged in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the tests!
For an example of how to fill this template out, see this Pull Request.
Description
This code provides alerts for important actions and notifications in a non-intrusive manner using toastify.
Related Issue
Closes #55
Acceptance Criteria
Type of Changes
enhancement
Updates
Before
After
Testing Steps / QA Criteria