-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add general styles 23 #49
Conversation
Visit the preview URL for this PR (updated for commit cf733e5): https://tcl-76-smart-shopping-list--pr49-sm-add-general-style-k5c0hxe8.web.app (expires Wed, 09 Oct 2024 16:34:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 512b1a88be8ae05fd3e727b99332819df760271d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
small blocker: Needed to run npm i
to get app to load on localhost. Need to make sure all dependencies are available.
nit-pick/non-blocking: Buttons and headings aren't styled. Curious what we think about merging this branch as it is, or if we should get buttons and headers styled before merging.
Definitely a nice start. Do you have some general/global styles for those headings and buttons? If so I think you can set and merge those in, and then dial them in as you start going through the components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the color and font changes. I agree with the idea of implementing a global style for the heading font and button styles to have a consistency across all pages.
Description
tailwind.config
filefont-archivo
inhome.jsx
as a previewRelated Issue
closes #42 (#23)
Acceptance Criteria
Type of Changes
enhancement
Updates
After
Testing Steps / QA Criteria
npm i
/npm install
font-archivo
as a class for specific elements as see the font difference. Right now it is only inHome.jsx
added as a class on theul
for the list of lists.