Fix spacing issue #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 200d6a6): https://tcl-79-smart-shopping-list--pr48-jo-fix-spacing-fc9ey4sj.web.app (expires Tue, 15 Oct 2024 10:31:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regex code replaced with another that removes spaces at the beginning and end of our items rather then all spaces and now allows spaces within the item name for items such as 'washing up liquid'.
Related Issue
Closes #45
Acceptance Criteria
Type of Changes
ImprovementUpdates
Before
After
Testing Steps / QA Criteria
git pullandgit checkout jo-fix-spacinghomepage click add new item and try adding an item with spaces either side and also try adding special characters and numbers