Mm feature/update listitem singlelist styling #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithin them after merge to match Figma design
…st` element and `NavBar`
…n with Figma design
|
Visit the preview URL for this PR (updated for commit 6a1fa8f): https://tcl-79-smart-shopping-list--pr51-mm-feature-update-li-bqb26als.web.app (expires Sat, 19 Oct 2024 12:40:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
Hudamabkhoot
requested changes
Oct 11, 2024
src/views/Layout.jsx
Outdated
| @@ -26,7 +26,8 @@ export function Layout() { | |||
| <div className="Layout text-black dark:text-white bg-white dark:bg-black"> | |||
| <NavBar darkMode={darkMode} toggleDarkMode={toggleDarkMode} /> | |||
|
|
|||
| <main className="mx-auto px-8 md:px-8 lg:px-20 w-full max-w-screen-sm min-h-screen flex flex-col"> | |||
| <main className="mx-auto px-8 md:px-8 lg:px-20 w-full max-w-screen-sm min-h-screen flex flex-col rounded-xl pt-20"> | |||
There was a problem hiding this comment.
Adding bottom padding here would be good so main isn't covered by the nav bar when you scroll to the bottom
joriordan332
requested changes
Oct 11, 2024
Wyna-7
approved these changes
Oct 11, 2024
|
@Wyna-7 I have swap them around on mobile it does look better i hope this is want your meant? |
|
@joriordan332 very good spot this one Jonathan👏🏾, forgot to check! |
|
@Hudamabkhoot for the labels I can't remove them for accessibility reason. I have added button padding very good spot!🤾🏾♀️ |
joriordan332
approved these changes
Oct 12, 2024
Hudamabkhoot
approved these changes
Oct 12, 2024
…item-singlelist-styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HomeandListpages, along with all accompanying files.NavBaris not too spaced out.Related Issue
Close #44, #47
Acceptance Criteria
The acceptance criteria for this PR are specified in Issue #14.
Type of Changes
Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g.,
bug fixorenhancementare common ones.enhancementfixUpdates
Before
DESKTOP
After
DESKTOP
MOBILE
Testing Steps / QA Criteria
git pullandgit checkout mm-feature/update-listitem-singlelist-stylingHomeandListpages you can see the styles implemented. You can toggle between Light mode and Dark mode to test the theme-switching functionality.Some styles might still need to be updated depending on the teams preference
maybe adding some sort of background behind list to break out the white and black backgrounds.