Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCP: Add support for option 108 "IPv6-Only Preferred" (RFC 8925) #1305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fxlb
Copy link
Member

@fxlb fxlb commented Mar 18, 2025

Add a test file with DHCP option 108 in both the request and the reply, provided by Bill.

@infrastation
Copy link
Member

I wonder how many more options that currently use l, L and i (zero or more 32-bit values) are specified as strictly 32-bit.

@infrastation
Copy link
Member

(The same stands for p, s and B.)

@fxlb
Copy link
Member Author

fxlb commented Mar 19, 2025

For B, it is clear that options 19, 20, 27, 29, 30, 31, 34, 36, 39 and 116 that use it are only 1 octet "0/1" boolean. No need for a while.

@infrastation
Copy link
Member

If a boolean option is specified as exactly one octet and it is not exactly one octet (0, 2, 3...), that means the option is malformed and ideally should be flagged in addition to being printed (if it is malformed, the usual next move is to see what's inside). Looks like a potential space for future improvements.

Add a test file with DHCP option 108 in both the request and the reply,
provided by Bill.
@fxlb fxlb force-pushed the IPv6-Only-Preferred branch from 7506397 to 1b31f22 Compare March 21, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants