theme(fix): social follow/share using new config #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit changed the config for social to use a map instead of a list, this broke the social share/follow, though a quick fix seems to restore it and removes the need for sorting
✅ Deploy Preview for ananke-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I also got into similar situation, im new to hugo, and trying to make social works, all I can track back is the follow.html and share.html. ill try to checkout this branch and see if it works! thanks @jerr0328 seems like I can not pull this branch as is, but currently I found another working branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit changed the config for social to use a map instead of a list, this broke the social share/follow, though a quick fix seems to restore it and removes the need for sorting.
Closes #808
I checked the wikipedia example from the original issue and it seems like this will also fix that. I'm not sure if you had anything else to fix, feel free to push to my branch.