Feature/delete nodes #21
Conversation
… deleteNodeWorks but connecting NodeFooter to global state, and then deleting the nodes data from the global state
…eactioncpacing, so i replaced it
jamesOConnell-REDspace
requested review from
tjgillis,
AMalley,
ngjmcdonald and
JonGardner-RedSpace
src/app/Nav.js
Outdated
| @@ -228,8 +228,8 @@ class Nav extends Component { | |||
| name="pageTitle" | |||
| fullWidth | |||
| style={styles.textField} | |||
| textareastyle={styles.textStyle} | |||
| hinttext="Page Title" | |||
| textareastyle={styles.textStyle} //I don't see this prop in the documentation | |||
src/node/fragments/NodeFooter.js
Outdated
| </Fragment> | ||
| ) | ||
| } | ||
| } from "../../store/actions" |
There was a problem hiding this comment.
Import from pages/PageActions. store/action will be deprecated, and will eventually be removed.
src/node/fragments/NodeFooter.js
Outdated
| } | ||
|
|
||
| // NOT SURE WHAT NEEDS TO BE SYNCED HERE |
There was a problem hiding this comment.
Comment isn't needed.
This function is mapping the current page in focus to the component's props, along with the scale of the scene.
There was a problem hiding this comment.
If you're not using scale or page in this component you can remove this function
There was a problem hiding this comment.
but mapState needs to exist in order for connect to work properly. What would i do instead?
There was a problem hiding this comment.
Pass null in its place instead. connect(null, { deleteAllLinks, deleteNode })(NodeFooter)
src/node/fragments/NodeFooter.js
Outdated
| } | ||
|
|
||
| // NOT SURE WHAT NEEDS TO BE SYNCED HERE |
There was a problem hiding this comment.
If you're not using scale or page in this component you can remove this function
src/node/fragments/NodeFooter.js
Outdated
| //id: PropTypes.string.isRequired, | ||
| setFocusedLink: PropTypes.func.isRequired, | ||
| class NodeFooter extends Component | ||
| { |
There was a problem hiding this comment.
I think having the brace dropped down goes against the convention throughout the rest of the app
definitely needs review, i wasn't sure about the mapState function, what needed to be in the arguments, and what needed to be mapped. But it successfully deletes the odes from the state, and renders properly