Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW FEATURE][WORK IN PROGRESS]Edit/Add/Delete Channels/Jobs #121

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

MatejMecka
Copy link
Collaborator

Thanks for showing interest in the project and sending us a pull request.

Please prefix your pull request with [NEW FEATURE], [BUG] or [IMPROVEMENT]


What issue/feature is fixed?

You can now Add Delete Edit Channels


Issue/Feature Details

You can mention the line of code that is causing the error, detail the feature you are requesting and where it can be useful.

[Your Text Here]


How To Test It Locally?

flask run

@thealphadollar
Copy link
Owner

Please resolve the conflicts and make me understand how does this interact with DB to add and edit channels data. Similarly for Jobs.

Copy link
Owner

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great PR; please introduce the changes I've requested.

nephos/web/info_panel/main/views.py Outdated Show resolved Hide resolved
nephos/web/info_panel/main/views.py Outdated Show resolved Hide resolved
tests/test_web/base.py Outdated Show resolved Hide resolved
tests/test_web/test_main.py Show resolved Hide resolved
Copy link
Owner

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update WIKI page .

@thealphadollar
Copy link
Owner

@MatejMecka Tests are still breaking.

@thealphadollar
Copy link
Owner

@MatejMecka Tests are still failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants