Skip to content

Commit

Permalink
DON-998: Add ticket numbers to regular giving todo comments
Browse files Browse the repository at this point in the history 
It's not obvious what to do with all the existing comments but I think
none of them need to be done urgently or a substantial enough to be
worth ticketing - maybe they are just things we can keep in mind and try
to either do or decide to remove while working on other regular giving
changes.

Remainig todos in this repo (including those with ticket nos added
here):

	$ git grep -ri todo-regular-giving .

	src/app/charity/charity.component.html:            <!-- @todo-regular-giving - update components to make moreInfoButton optional and remove in the case of
	src/app/mandate.model.ts:  // @todo-regular-giving-DON-1008 : we might want to keep the total donated amount as part of the regular giving mandate
	src/app/mandate/mandate.component.html:        <!--            @todo-regular-giving: consider adding thank you message in matchbot / SF-->
	src/app/mandate/mandate.component.html:            <!--  @todo-regular-giving-DON-1008: consider displaying gift Aid and tip amount on the template (format copied from one-off cmpaign thank you page -->
	src/app/mandate/mandate.component.html:            <!--                @todo-regular-giving-DON-1008: use giftAid value sent from matchbot (possibly also the matched amounts calculations -->
	src/app/mandate/mandate.component.ts:  // @todo-regular-giving: calculate the total in matchbot and show on template
	src/app/regular-giving/regular-giving.component.html:                <!-- @todo-regular-giving-DON-1021 - make each or all payment detail fields read-only if already set on
	src/app/regular-giving/regular-giving.component.html:                  <!-- @todo-regular-giving-DON-1021: show existing payment method here, and/or on account page -->
	src/app/regular-giving/regular-giving.component.html:                    (todo-regular-giving-DON-1021: replace this paragraph with an element showing details of the saved method)
	src/app/regular-giving/regular-giving.component.html:              <p>(todo-regular-giving-OPS-766: add link to regular giving terms & conditions)</p>
	src/app/regular-giving/regular-giving.component.ts:     * @todo-regular-giving consider if we need to send this from FE - if we're not displaying it to donor better for matchbot to
	src/app/regular-giving/regular-giving.component.ts:    // no-op for now, but @todo-regular-giving we may need to do some validation as we don the ad-hoc donation page.

	# Please enter the commit message for your changes. Lines starting
	# with '#' will be ignored, and an empty message aborts the commit.
	#
	# Date:      Tue Jan 21 10:39:03 2025 +0000
	#
	# On branch DON-998-regular-giving-cont
  • Loading branch information
@bdsl
bdsl committed Jan 21, 2025
1 parent cfcf4cc commit da67b98
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/app/mandate/mandate.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ <h2>Thank you!</h2>
<th scope="row">Matched Amount (for the first {{ mandate.numberOfMatchedDonations }} months)</th>
<td>{{ mandate.matchedAmount.amountInPence / 100 | exactCurrency:mandate.donationAmount.currency }}</td>
</tr>
<!-- @todo-regular-giving: consider displaying gift Aid and tip amount on the template (format copied from one-off cmpaign thank you page -->
<!-- @todo-regular-giving-DON-1008: consider displaying gift Aid and tip amount on the template (format copied from one-off cmpaign thank you page -->
<!-- @if (giftAidAmount > 0) {-->
<!-- <tr>-->
<!-- <th scope="row">Gift Aid Amount</th>-->
Expand All @@ -65,7 +65,7 @@ <h2>Thank you!</h2>
<hr aria-hidden="true">
</td>
</tr>
<!-- @todo-regular-giving: use giftAid value sent from matchbot (possibly also the matched amounts calculations -->
<!-- @todo-regular-giving-DON-1008: use giftAid value sent from matchbot (possibly also the matched amounts calculations -->
<tr class="receives">
<th scope="row">Charity Receives (Matched Donations)</th>
<td>{{ (mandate.donationAmount.amountInPence + mandate.matchedAmount.amountInPence) / 100 + ' ' | exactCurrency:mandate.donationAmount.currency }}</td>
Expand Down
8 changes: 4 additions & 4 deletions src/app/regular-giving/regular-giving.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,18 +77,18 @@
>
<p> <!-- hack to take up space until I find a better way -->

<!-- @todo-regular-giving - make each or all payment detail fields read-only if already set on
<!-- @todo-regular-giving-DON-1021 - make each or all payment detail fields read-only if already set on
donor account - if donors want to edit them direct them to do so on the My Account page,
to make clear that it will affect existing mandates as well as the new one -->

@if (donorAccount.regularGivingPaymentMethod) {
<!-- @todo-regular-giving: show existing payment method here, and/or on account page -->
<!-- @todo-regular-giving-DON-1021: show existing payment method here, and/or on account page -->
<p style="border: 2px solid blue; background: pink">
Your existing regular giving payment method {{ donorAccount.regularGivingPaymentMethod }}
will be used for these donations.
To change this please visit your account page

(todo-regular-giving: replace this paragraph with an element showing details of the saved method)
(todo-regular-giving-DON-1021: replace this paragraph with an element showing details of the saved method)
</p>
} @else {
<biggive-text-input>
Expand Down Expand Up @@ -168,7 +168,7 @@
<mat-icon class="b-va-bottom" aria-hidden="false" aria-label="Open in new tab">open_in_new</mat-icon>
read our Privacy Statement.</a>
</p>
<p>(todo-regular-giving: add link to regular giving terms & conditions)</p>
<p>(todo-regular-giving-OPS-766: add link to regular giving terms & conditions)</p>

@if (submitErrorMessage) {
<div
Expand Down

0 comments on commit da67b98

Please sign in to comment.