Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON-998: add resolver for an single mandate #1801

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

dorota-joanna
Copy link
Contributor

No description provided.

if (!mandateId) {
throw new Error('mandateId param missing in route');
}
const mandate$ = mandateService.getActiveMandate(mandateId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const mandate$ = mandateService.getActiveMandate(mandateId);

bdsl
bdsl previously approved these changes Dec 16, 2024
Copy link
Contributor

@bdsl bdsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will be broken right now as we need an update to the mandate API model in matchbot but that's OK, we're not relying on mandate stuff working just yet.

@dorota-joanna dorota-joanna marked this pull request as ready for review December 16, 2024 18:19
@dorota-joanna dorota-joanna merged commit c52040c into develop Dec 16, 2024
2 of 3 checks passed
@dorota-joanna dorota-joanna deleted the DON-998-fetch-one-mandate-from-matchbot branch December 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants