Don 518 explore meta campaign fixes #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges to filter/sort Issue reported in Jira comment 16 December 2024 at 12:12 I initially looked for a wy to find the campaign slug to use for navigation but that isn't part of the model, and then I realised I could just copy the code for this line from the old meta-campaign code - following is the version live now. https://github.com/thebiggive/donate-frontend/blob/36cc52e9a883fe1e33b013e1515503ee574fb3b7/src/app/meta-campaign/meta-campaign.component.ts
bdsl
force-pushed
the
DON-518-explore-meta-campaign-fixes
branch
from
5fa6039 to
e26714e
Compare
Initially tried copying code from the old explore page at https://github.com/thebiggive/donate-frontend/blob/36cc52e9a883fe1e33b013e1515503ee574fb3b7/src/app/explore/explore.component.ts#L162 but that actually just does the same thing as the `doCampaignSearch` function that we already have, so we just need to call that unconditionally for both the campaign and explore pages. Also switched away from the deprecated usage of Observable.subscribe with two params
bdsl
force-pushed
the
DON-518-explore-meta-campaign-fixes
branch
from
e26714e to
8096ab0
Compare
NoelLH
previously approved these changes
Dec 17, 2024
src/app/explore/explore.component.ts
Outdated
| @@ -357,6 +357,7 @@ export class ExploreComponent implements AfterViewChecked, OnDestroy, OnInit { | |||
| } | |||
|
|
|||
| private loadMoreForCurrentSearch() { | |||
| console.log("in loadmoreForCurrentSearch"); | |||
There was a problem hiding this comment.
Suggested change
| console.log("in loadmoreForCurrentSearch"); |
Unless this is useful for verifying in Staging for now?
There was a problem hiding this comment.
No, left in by mistake.
bdsl
commented
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.