DON-1014: Move total raised right on regular giving campaign summary … #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…card Also allowing regular giving & ad-hoc to be mixed in the same grid
bdsl
commented
Jan 17, 2025
| @@ -1,5 +1,6 @@ | |||
| export type CampaignSummary = { | |||
| percentRaised?: number|string; | |||
| isRegularGiving: boolean; | |||
There was a problem hiding this comment.
this needs to be added in SF where we send these summaries. Doesn't actually have to be done before this is deployed to prod as long as there are no regular giving campaigns in prod since undefined is falsy.
bdsl
commented
Jan 17, 2025
Comment on lines
70
to
72
| @for (campaign of individualCampaigns; track campaign.id) { | ||
| <div> | ||
| @if (campaign.isRegularGiving) { |
There was a problem hiding this comment.
I think I'm likely to extract everything inside this if soon to go into a new Angular component to re-use in charity.component.html
This reverts commit 1f288d2.
This reverts commit 7092a70. I couldn't get the layout quite right on the explore page with the new campaign-card component - it wasn't filling the full height of the space in the grid when it was shorter than other cards (e.g. not having a percentage raised or having a single line title)
…ore, metacampaign & charity pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allowing regular giving & ad-hoc to be mixed in the same grid