DON-998: Remove & add ticket numbers to already-done regular-giving todo comments #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not obvious what to do with all the existing comments but I think none of them need to be done urgently or a substantial enough to be worth ticketing - maybe they are just things we can keep in mind and try to either do or decide to remove while working on other regular giving changes. Remainig todos in this repo (including those with ticket nos added here): $ git grep -ri todo-regular-giving . src/app/charity/charity.component.html: <!-- @todo-regular-giving - update components to make moreInfoButton optional and remove in the case of src/app/mandate.model.ts: // @todo-regular-giving-DON-1008 : we might want to keep the total donated amount as part of the regular giving mandate src/app/mandate/mandate.component.html: <!-- @todo-regular-giving: consider adding thank you message in matchbot / SF--> src/app/mandate/mandate.component.html: <!-- @todo-regular-giving-DON-1008: consider displaying gift Aid and tip amount on the template (format copied from one-off cmpaign thank you page --> src/app/mandate/mandate.component.html: <!-- @todo-regular-giving-DON-1008: use giftAid value sent from matchbot (possibly also the matched amounts calculations --> src/app/mandate/mandate.component.ts: // @todo-regular-giving: calculate the total in matchbot and show on template src/app/regular-giving/regular-giving.component.html: <!-- @todo-regular-giving-DON-1021 - make each or all payment detail fields read-only if already set on src/app/regular-giving/regular-giving.component.html: <!-- @todo-regular-giving-DON-1021: show existing payment method here, and/or on account page --> src/app/regular-giving/regular-giving.component.html: (todo-regular-giving-DON-1021: replace this paragraph with an element showing details of the saved method) src/app/regular-giving/regular-giving.component.html: <p>(todo-regular-giving-OPS-766: add link to regular giving terms & conditions)</p> src/app/regular-giving/regular-giving.component.ts: * @todo-regular-giving consider if we need to send this from FE - if we're not displaying it to donor better for matchbot to src/app/regular-giving/regular-giving.component.ts: // no-op for now, but @todo-regular-giving we may need to do some validation as we don the ad-hoc donation page. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Date: Tue Jan 21 10:39:03 2025 +0000 # # On branch DON-998-regular-giving-cont
bdsl
changed the title
NoelLH
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.