ID-48: Remove completed command #191
Merged
+31
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I anticipate this command being completed in prod in the next few hours, and then we won't need to ever run it again.
bdsl
force-pushed
the
ID-48-remove-command
branch
from
c31c98d to
28dca60
Compare
bdsl
commented
Jan 7, 2025
| @@ -0,0 +1,31 @@ | |||
| <?php | |||
There was a problem hiding this comment.
technically this migration should be deployed after the other changes in this PR, but in practice it doesn't matter if its a few seconds earlier.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #191 +/- ##
===========================================
+ Coverage 69.22% 71.57% +2.35%
===========================================
Files 41 40 -1
Lines 1004 971 -33
===========================================
Hits 695 695
+ Misses 309 276 -33 ☔ View full report in Codecov by Sentry. |
NoelLH
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I anticipate this command being completed in prod in the next few hours, and then we won't need to ever run it again.