DON-998 - rename limit

thebiggive · Jan 3, 2025 · f8f1ad7 · f8f1ad7
1 parent 06be75c
commit f8f1ad7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/Domain/DoctrineDonationRepository.php b/src/Domain/DoctrineDonationRepository.php
@@ -744,7 +744,7 @@ public function findAllCompleteForCustomer(StripeCustomerId $stripeCustomerId):
     /**
      * We only set Payment Intent on the day of the payment due to stripe limitations, see
      */
-    public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $limit): array
+    public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $maxBatchSize): array
     {
         $preAuthorized = DonationStatus::PreAuthorized->value;
         $active = MandateStatus::Active->value;
@@ -753,12 +753,14 @@ public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime,
         $query = $this->getEntityManager()->createQuery(<<<DQL
             SELECT donation from Matchbot\Domain\Donation donation JOIN donation.mandate mandate
             WHERE donation.donationStatus = '$preAuthorized'
+            AND donation.transactionId = null
+            AND donation.preAuthorizationDate <= $atDateTime
             AND mandate.status = '$active'
             AND mandate.dayOfMonth.value = '$dayOfMonthToday'
         DQL
         );
 
-        $query->setMaxResults($limit);
+        $query->setMaxResults($maxBatchSize);
 
         /** @var list<Donation> $result */
         $result = $query->getResult();

diff --git a/src/Domain/DonationRepository.php b/src/Domain/DonationRepository.php
@@ -153,7 +153,7 @@ public function findAllCompleteForCustomer(StripeCustomerId $stripeCustomerId):
     /**
      * @return list<Donation>
      */
-    public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $limit): array;
+    public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $maxBatchSize): array;
 
     /**
      * @return list<Donation>

diff --git a/tests/Domain/InMemoryDonationRepository.php b/tests/Domain/InMemoryDonationRepository.php
@@ -187,7 +187,7 @@ public function totalMatchFundsReleased(): string
         throw new \Exception("Method not implemented in test double");
     }
 
-    #[\Override] public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $limit): array
+    #[\Override] public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $maxBatchSize): array
     {
         throw new \Exception("Method not implemented in test double");
     }