DON-998: Stop assuming donations will always have transaction IDs #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdsl
force-pushed
the
DON-998-allow-donations-without-transaction-id
branch
3 times, most recently
from
8ed61f4 to
9a97084
Compare
This throw causes crashes in the regular giving form, and the assumption that almost every donation will have a non-null transaction ID stops being true when we launch regular giving, as for the 2nd and 3rd donations of each mandate there will be 1 and 2 month delays between donation creation and transaction id creation.
bdsl
force-pushed
the
DON-998-allow-donations-without-transaction-id
branch
from
9a97084 to
abadb0d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1157 +/- ##
===========================================
+ Coverage 74.28% 74.36% +0.07%
===========================================
Files 128 128
Lines 5588 5601 +13
===========================================
+ Hits 4151 4165 +14
+ Misses 1437 1436 -1 ☔ View full report in Codecov by Sentry. |
NoelLH
previously approved these changes
Jan 7, 2025
| * NOT include an assertion that the donation has a transaction ID, as that is only required for confirmation, not | ||
| * for pre-auth. | ||
| */ | ||
| private function assertionsForConfirmOrPreAuth(): \Assert\LazyAssertion |
There was a problem hiding this comment.
Liking that these end up very clear in terms of what they allow, and DRY
Thanks! I think I'll wait until after #1151 is merged before merging this to avoid creating merge conflicts over there. |
…tions-without-transaction-id
bdsl
force-pushed
the
DON-998-allow-donations-without-transaction-id
branch
from
3687710 to
1ba369e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This throw causes crashes in the regular giving form, and the assumption that almost every donation will have a non-null transaction ID stops being true when we launch regular giving, as for the 2nd and 3rd donations of each mandate there will be 1 and 2 month delays between donation creation and transaction id creation.