Skip to content

Commit

Permalink
auth: add copy constructor for firebase::auth::Auth on Android
Browse files Browse the repository at this point in the history
Add the copy constructor on Android as well to ensure that the type is
imported properly by the clang importer when bridging to Swift.
  • Loading branch information
compnerd authored and kendalharland committed Aug 3, 2024
1 parent 21c1938 commit 42ea1bf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion auth/src/auth_swift.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#define __swift__ 50000
#include "auth/src/include/firebase/auth.h"

#if FIREBASE_PLATFORM_WINDOWS
#if FIREBASE_PLATFORM_WINDOWS || FIREBASE_PLATFORM_ANDROID
namespace firebase {
namespace auth {
Auth::Auth(const Auth &) noexcept = default;
Expand Down
2 changes: 1 addition & 1 deletion auth/src/include/firebase/auth.h
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class Auth {
~Auth();

#if defined(__swift__)
#if FIREBASE_PLATFORM_WINDOWS
#if FIREBASE_PLATFORM_WINDOWS || FIREBASE_PLATFORM_ANDROID
// TODO(apple/swift#67288) support trivial C++ types with non-trivial dtors
Auth(const Auth&) noexcept;
#endif
Expand Down

0 comments on commit 42ea1bf

Please sign in to comment.