forked from firebase/firebase-cpp-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland changes to target avx2 #38
Merged
kendalharland
merged 1 commit into
compnerd/swift
from
kendal/devin-1380-reland-changes-to-target-avx2-in-firebase-cpp-sdk
May 15, 2024
Merged
Reland changes to target avx2 #38
kendalharland
merged 1 commit into
compnerd/swift
from
kendal/devin-1380-reland-changes-to-target-avx2-in-firebase-cpp-sdk
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kendalharland
changed the title
Reland changes to target avx2 in firebase cpp sdk
Reland changes to target avx2
May 15, 2024
sebmarchand
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For relands I usually like having some explanation of why it's safe to reland this in the PR description.
Ah, good idea. Updated |
kendalharland
deleted the
kendal/devin-1380-reland-changes-to-target-avx2-in-firebase-cpp-sdk
branch
May 15, 2024 23:04
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
May 25, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jun 1, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Aug 3, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 7, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: kendal <[email protected]>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Co-authored-by: kendal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add build flags to target avx2.
This was previously reverted because it was falsely identified as the cause of a bcny-firebase.yml build breakage - the true culprit was a buggy flag set in curl's cmake configuration which was fixed in #30
Testing
Presubmit
Type of Change