Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland changes to target avx2 #38

Conversation

kendalharland
Copy link
Collaborator

@kendalharland kendalharland commented May 15, 2024

Description

Add build flags to target avx2.

This was previously reverted because it was falsely identified as the cause of a bcny-firebase.yml build breakage - the true culprit was a buggy flag set in curl's cmake configuration which was fixed in #30

Testing

Presubmit

Type of Change

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@kendalharland kendalharland changed the title Reland changes to target avx2 in firebase cpp sdk Reland changes to target avx2 May 15, 2024
Copy link

@sebmarchand sebmarchand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For relands I usually like having some explanation of why it's safe to reland this in the PR description.

@kendalharland
Copy link
Collaborator Author

For relands I usually like having some explanation of why it's safe to reland this in the PR description.

Ah, good idea. Updated

@kendalharland kendalharland merged commit 1917cf3 into compnerd/swift May 15, 2024
6 checks passed
@kendalharland kendalharland deleted the kendal/devin-1380-reland-changes-to-target-avx2-in-firebase-cpp-sdk branch May 15, 2024 23:04
github-actions bot pushed a commit that referenced this pull request May 16, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request May 25, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request May 31, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request Jun 1, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request Jun 7, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request Jul 16, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request Jul 18, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 3, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 6, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 21, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 7, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 11, 2024
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants