Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial android support for the firebase BCNY workflow #41

Merged
merged 1 commit into from
May 20, 2024

Conversation

hyp
Copy link

@hyp hyp commented May 17, 2024

the android build is based on the original google android build.

I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.

the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
@hyp
Copy link
Author

hyp commented May 17, 2024

Copy link

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can iterate on this once committed.

cmake_build $arch "firestore" "-DFIREBASE_CPP_USE_PRIOR_GRADLE_BUILD=ON -DFIREBASE_INCLUDE_FIRESTORE=ON"
cmake_build $arch "auth" "-DFIREBASE_CPP_USE_PRIOR_GRADLE_BUILD=ON -DFIREBASE_INCLUDE_AUTH=ON"
cmake_build $arch "functions" "-DFIREBASE_CPP_USE_PRIOR_GRADLE_BUILD=ON -DFIREBASE_INCLUDE_FUNCTIONS=ON"
cmake_build $arch "remote_config" "-DFIREBASE_CPP_USE_PRIOR_GRADLE_BUILD=ON -DFIREBASE_INCLUDE_REMOTE_CONFIG=ON"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like its building more than we do on Windows, but I think that getting it built is more important than optimizing right now.

while IFS= read -r file; do
cp "$file" "$destination_dir"
echo "Copied: $file"
done < <(find $source -type f -name "*.a")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we cannot use an install target from CMake? :(

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no unfortunately

@hyp hyp merged commit 19bffb1 into compnerd/swift May 20, 2024
9 checks passed
@hyp hyp deleted the eng/android1 branch May 20, 2024 15:49
bcny-fork-syncer bot pushed a commit that referenced this pull request May 25, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request May 31, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request Jun 1, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request Jun 7, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request Jul 16, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request Jul 18, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 3, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 6, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 21, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 7, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 11, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 12, 2024
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify
the currently built libraries first to see if I need more libraries like abseil on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants