-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial android support for the firebase BCNY workflow #41
Conversation
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can iterate on this once committed.
cmake_build $arch "firestore" "-DFIREBASE_CPP_USE_PRIOR_GRADLE_BUILD=ON -DFIREBASE_INCLUDE_FIRESTORE=ON" | ||
cmake_build $arch "auth" "-DFIREBASE_CPP_USE_PRIOR_GRADLE_BUILD=ON -DFIREBASE_INCLUDE_AUTH=ON" | ||
cmake_build $arch "functions" "-DFIREBASE_CPP_USE_PRIOR_GRADLE_BUILD=ON -DFIREBASE_INCLUDE_FUNCTIONS=ON" | ||
cmake_build $arch "remote_config" "-DFIREBASE_CPP_USE_PRIOR_GRADLE_BUILD=ON -DFIREBASE_INCLUDE_REMOTE_CONFIG=ON" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like its building more than we do on Windows, but I think that getting it built is more important than optimizing right now.
while IFS= read -r file; do | ||
cp "$file" "$destination_dir" | ||
echo "Copied: $file" | ||
done < <(find $source -type f -name "*.a") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, we cannot use an install target from CMake? :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no unfortunately
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build. I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.
the android build is based on the original google android build.
I omitted the NuGet packaging for android for now, as I want to verify the currently built libraries first to see if I need more libraries like abseil on Windows.