Copy over headers we use for firebase for the android distribution #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to try it out in the firebase CI / local builds. |
compnerd
reviewed
Aug 31, 2024
|
Updated, merging |
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 7, 2024
* Copy over headers we use for firebase for the android distribution * update the install step for headers for review comment
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
* Copy over headers we use for firebase for the android distribution * update the install step for headers for review comment
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
* Copy over headers we use for firebase for the android distribution * update the install step for headers for review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the android firebase-cpp-sdk to also include the headers we use in the windows distribution in the android distribution as well.
Testing
Manual workflow run.
Type of Change
Place an
xthe applicable box: