IWeakReferenceSource support #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanlabelle
commented
Mar 29, 2024
There was a problem hiding this comment.
@stevenbrix I think I have most of the implementation but I'm blocked at this point. When I start going down the WeakReferenceSource creation, I don't have a COM object anymore and eventually I need it again for queryInterface implementations. I don't understand how it works in this codebase.
jeffdav
approved these changes
Mar 29, 2024
stevenbrix
approved these changes
Mar 29, 2024
@stevenbrix No, I think that implementation would look quite different, and likely much simpler. |
tristanlabelle
force-pushed
the
tristan/IWeakReferenceSource-support
branch
from
06b1d1a
to
26a9131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
IWeakReferenceSourceon the COM interface that we synthesize for Swift objects sent to WinRT. This allows WinUI to keep weak references to our Swift objects. Also adds tests.