Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less clever #includes for IWeakReference #153

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Apr 1, 2024

The previous implementation caused errors when including CWinRT.h into a bigger project. This was most likely due to the #define CINTERFACE, an attempt at avoiding to have to redefine system COM objects to ensure a C-language definition. This change rather uses the tried-and-tested way to define a C interface with the GUID workaround.

@tristanlabelle tristanlabelle marked this pull request as ready for review April 1, 2024 14:15
@tristanlabelle tristanlabelle requested a review from a team as a code owner April 1, 2024 14:15
@tristanlabelle tristanlabelle merged commit 54f6187 into main Apr 1, 2024
1 check passed
@tristanlabelle tristanlabelle deleted the tristan/WeakReference-less-clever branch April 1, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants