Pin gha-setup-vsdevenv #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Jun 7, 2024
kendalharland
force-pushed
the
kendal/fix-cmake-not-found
branch
from
2dcbe61
to
643c49a
Compare
kendalharland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action
compnerd/gha-setup-swiftwas modified to skip callingcompnerd/gha-setup-vsdevenvinternally when swift is newer than 5.9, because this previously only done as part of a workaround where the swift compiler's module maps could not be located. This is problematic because the latter sets environment variables necessary for the build, including PATH.These actions were both pinned to
mainresulting in incompatible versions being used. They're now both pinned to the explicit commits on main (at the time of writing).