Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make internals public but behind spi #184

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

stevenbrix
Copy link
Collaborator

this pr makes the internals public, since it doesn't affect the export count on debug builds and puts them all behind @_spi(WinRTInternal). this will make it easier to fall back to something like this for accessing the throwing set/get of properties

let abi: __ABI_Microsoft_UI_Xaml.IFoo = try swift.thisPtr.QueryInterface()
let foo = try abi.get_Foo()

@stevenbrix stevenbrix requested a review from a team as a code owner September 6, 2024 16:42
@stevenbrix stevenbrix merged commit 1efc208 into main Sep 6, 2024
1 check passed
@stevenbrix stevenbrix deleted the steve/make-internals-public branch September 6, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants