Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Customer backend - VIEW fix #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mandixx
Copy link

@mandixx mandixx commented Dec 19, 2022

edit customer fix
Hey, I've fixed the Edit customer view which was throwing an error if there is no billing or shipping information attached to the customer.
Can you have a look ?

Commit MSG:
CustomerResource response changed.
Backend customer edit view changed to show that there is no billing or shipping inforamtion if there is no any.

Backend customer edit view changed to show that there is no billing or shipping inforamtion if there is no any.
@mandixx mandixx changed the title CustomerResource response changed. Edit Customer backend - VIEW fix Dec 19, 2022
Copy link

@arkohaddoebenezer arkohaddoebenezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good if you make available a button to take the users to provide address info other than simple displaying no address message

@@ -26,12 +26,15 @@
<CustomInput v-else type="select" :select-options="billingStateOptions"
v-model="customer.billingAddress.state" label="State"/>
</div>
<p v-else class="text-center py-8 text-gray-700">
There are is no billing address

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

direct users to provide billing address

@@ -42,6 +45,9 @@
<CustomInput v-else type="select" :select-options="shippingStateOptions"
v-model="customer.shippingAddress.state" label="State"/>
</div>
<p v-else class="text-center py-8 text-gray-700">
There are is no shipping address

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants