Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 🇯🇵 Japanese translation #127

Merged
merged 6 commits into from
May 19, 2020
Merged

Add 🇯🇵 Japanese translation #127

merged 6 commits into from
May 19, 2020
+2 −0

Conversation

53able
Copy link

@53able 53able commented Apr 23, 2020 •
edited
Loading

resolve #100

  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Short description of what this resolves:

Missing Japanese translation

Proposed changes:

Add Japanese translation link in the README

👍 Thank you!

@53able 53able changed the title [WIP] Add 🇯🇵 Japaneseh translation Add 🇯🇵 Japaneseh translation Apr 23, 2020
@53able 53able changed the title Add 🇯🇵 Japaneseh translation Add 🇯🇵 Japanese translation Apr 23, 2020
@53able
Copy link
Author

53able commented May 19, 2020

@thedaviddias
Ready to merge :)

@thedaviddias thedaviddias merged commit f5e8cc6 into thedaviddias:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Japanese translation
2 participants
@53able @thedaviddias