Fix image builder #3544
Merged
Fix image builder #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for 58c5923 is available at theforeman-foreman-documentation-preview-pr-3544.surge.sh The following output files are affected by this PR: |
maximiliankolb
commented
Jan 2, 2025
| @@ -65,8 +65,3 @@ This creates a new `rhel6-cloud.qcow2` file in the location where you enter the | |||
| ==== | |||
| You must manually resize the partitions of instances based on the image in accordance with the disk space in the flavor that is applied to the instance. | |||
There was a problem hiding this comment.
I consider this out of scope unless someone provides a suggestion.
Lennonka
approved these changes
Jan 8, 2025
| @@ -10,8 +10,10 @@ include::modules/proc_registering-a-host.adoc[leveloffset=+1] | |||
|
|
|||
| include::modules/proc_installing-and-configuring-puppet-agent-manually.adoc[leveloffset=+1] | |||
|
|
|||
| ifdef::satellite[] | |||
There was a problem hiding this comment.
I'm not sure. Aren't they still relevant for upstream?
There was a problem hiding this comment.
Technically yes, upstream users could still use RHEL 6 (???) or RHEL 7/Oracle Linux 7 with paid support. Though I'd argue that it's OK to drop this by now.
line 13 was basically a judgement call by me. I am happy to adjust this to "if not orcharhino".
maximiliankolb
force-pushed
the
fix_image_builder
branch
from
58c5923 to
1606608
Compare
maximiliankolb
force-pushed
the
fix_image_builder
branch
from
1606608 to
ae9941d
Compare
maximiliankolb
added
style review done
|
PR was agreed upon in chat. |
maximiliankolb
added a commit
that referenced
this pull request
Feb 5, 2025
* Show custom EL7+EL6 images for Satellite only * Use dashes in favor of underscores in file names * Remove duplicate next steps (cherry picked from commit fefd696)
maximiliankolb
added a commit
that referenced
this pull request
Feb 5, 2025
* Show custom EL7+EL6 images for Satellite only * Use dashes in favor of underscores in file names * Remove duplicate next steps (cherry picked from commit fefd696)
maximiliankolb
removed
the
Needs tech review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
hide procedures for upstream that are only relevent for RHEL7/6 + some minor cleanup
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
?
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
please review commit by commit; I suggest to squash the commits before merging unless someone comments otherwise.
Checklists
Please cherry-pick my commits into: