Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package cleanup for EL 8+ cloud-init images #3600

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Update package cleanup for EL 8+ cloud-init images #3600

merged 2 commits into from
Mar 10, 2025
+13 −1

Conversation

Lennonka
Copy link
Contributor

What changes are you introducing?

Adding a package clean-up command for EL 8+

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

The previous command only works until EL 7

Bug SAT-24621 (public)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

  • I haven't tested the new command but it's based on a RH knowledgebase solution

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@Lennonka Lennonka added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Jan 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

The PR preview for 8363662 is available at theforeman-foreman-documentation-preview-pr-3600.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@Lennonka
Copy link
Contributor Author

Lennonka commented Mar 3, 2025

@stejskalleos Like this?

stejskalleos
stejskalleos approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@stejskalleos stejskalleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 LGTM

@Lennonka Lennonka added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Mar 4, 2025
maximiliankolb
maximiliankolb approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked via "dnf remove --help" on EL9. ✔️

style-wise LGTM

@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Mar 10, 2025
@Lennonka Lennonka merged commit 294a79c into theforeman:master Mar 10, 2025
8 of 9 checks passed
Lennonka added a commit that referenced this pull request Mar 10, 2025
@Lennonka
Update package cleanup for EL 8+ cloud-init images (#3600)
2404bd9
Lennonka added a commit that referenced this pull request Mar 10, 2025
@Lennonka
Update package cleanup for EL 8+ cloud-init images (#3600)
73bf19a
Lennonka added a commit that referenced this pull request Mar 10, 2025
@Lennonka
Update package cleanup for EL 8+ cloud-init images (#3600)
6e1c240
Lennonka added a commit that referenced this pull request Mar 10, 2025
@Lennonka
Update package cleanup for EL 8+ cloud-init images (#3600)
8d15c11
Lennonka added a commit that referenced this pull request Mar 10, 2025
@Lennonka
Update package cleanup for EL 8+ cloud-init images (#3600)
64f4956
Lennonka added a commit that referenced this pull request Mar 10, 2025
@Lennonka
Update package cleanup for EL 8+ cloud-init images (#3600)
04fa5e9
Lennonka added a commit that referenced this pull request Mar 10, 2025
@Lennonka
Update package cleanup for EL 8+ cloud-init images (#3600)
b6845e6
Lennonka added a commit that referenced this pull request Mar 10, 2025
@Lennonka
Update package cleanup for EL 8+ cloud-init images (#3600)
76f003e
@Lennonka
Copy link
Contributor Author

Cherry picked:

@Lennonka Lennonka deleted the update-packagecleanup-command-cloudinit branch March 10, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

@stejskalleos stejskalleos stejskalleos approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lennonka @maximiliankolb @stejskalleos