Deprecate KubeVirt compute resource #3619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for 54d5da5 is available at theforeman-foreman-documentation-preview-pr-3619.surge.sh The following output files are affected by this PR: |
There was a problem hiding this comment.
diff looks very similar to #3616. So you'll probably want to rebase after merging 3616. Also, I am kinda surprised: https://www.redhat.com/en/blog/introducing-red-hat-openshift-virtualization-engine
|
Waiting for #3616 to be merged. |
Lennonka
force-pushed
the
deprecate-kubevirt
branch
from
5bf71b3 to
54d5da5
Compare
Lennonka
added
Needs tech review
|
ACK |
Lennonka
added
tech review done
maximiliankolb
added
style review done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Adding deprecation notice for KubeVirt compute resource
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
SAT-29985 (private)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: F3.14