Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize Planning for Foreman guide #3626

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Modularize Planning for Foreman guide #3626

merged 3 commits into from
Jan 31, 2025

Conversation

maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Jan 30, 2025 •
edited
Loading

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

  • Preparation to adjust the guide for downstream

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

  • I made the least amount of changes to simplify review: move first, edit second (follow-up PR)
  • Please review by looking at the rendered diff provided by "show diff as HTML".

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

The PR preview for af4b64f is available at theforeman-foreman-documentation-preview-pr-3626.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@maximiliankolb maximiliankolb force-pushed the modularize_planning_for_foreman branch from 6983eef to a9fa831 Compare January 30, 2025 13:06
@maximiliankolb maximiliankolb marked this pull request as ready for review January 30, 2025 13:13
Lennonka
Lennonka reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two nitpicks.
The provisioning needs updating, but that's out of scope for this PR.

guides/common/modules/con_provisioning-concepts.adoc Outdated Show resolved Hide resolved
guides/common/modules/con_secure-boot.adoc Outdated Show resolved Hide resolved
@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Jan 31, 2025
@maximiliankolb maximiliankolb force-pushed the modularize_planning_for_foreman branch from a9fa831 to af4b64f Compare January 31, 2025 09:41
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Jan 31, 2025
maximiliankolb
maximiliankolb commented Jan 31, 2025
View reviewed changes
Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied both suggestions. Kindly asking for a re-review.

guides/common/modules/con_provisioning-concepts.adoc Outdated Show resolved Hide resolved
guides/common/modules/con_secure-boot.adoc Outdated Show resolved Hide resolved
Lennonka
Lennonka approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@maximiliankolb maximiliankolb merged commit fbc716d into theforeman:master Jan 31, 2025
9 checks passed
@maximiliankolb maximiliankolb deleted the modularize_planning_for_foreman branch January 31, 2025 09:50
@maximiliankolb
Copy link
Contributor Author

Merged to "master". I did not cherry-pick to 3.13 or 3.12 because there were many merge conflicts because previous commits have not been cherry-picked either. This is OK for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lennonka Lennonka Lennonka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximiliankolb @Lennonka