Fixes #29541: Use Facter 4 in testing

Drops pinned dependencies in Gemfile.

.travis.yml

@@ -1,4 +1,3 @@
-sudo: false
 language: ruby
 addons:
   apt:
@@ -8,9 +7,7 @@ addons:
     - xsltproc
     - docbook-xsl
     - ca-certificates
-rvm: 2.4
-env:
-  - PUPPET_VERSION=5.0
+rvm: 2.5
 script:
   - bundle exec rake rubocop
   #
@@ -23,8 +20,11 @@ script:
   - INSTDIR=$(mktemp -d)
   - bundle exec rake build install PREFIX=$INSTDIR
   - bundle exec $INSTDIR/sbin/foreman-installer --help --scenario foreman
+  - cat $INSTDIR/var/log/foreman-installer/foreman.log
   - bundle exec $INSTDIR/sbin/foreman-installer --help --scenario foreman-proxy-content
+  - cat $INSTDIR/var/log/foreman-installer/foreman-proxy-content.log
   - bundle exec $INSTDIR/sbin/foreman-installer --help --scenario katello
+  - cat $INSTDIR/var/log/foreman-installer/katello.log
   - bundle exec $INSTDIR/sbin/foreman-proxy-certs-generate --help
   - bundle exec $INSTDIR/sbin/foreman-proxy-certs-generate --help |grep -q certs-update-server
   #

Gemfile

@@ -3,27 +3,18 @@ source 'https://rubygems.org'
 gem 'kafo', '~> 4.1'
 gem 'librarian-puppet'
 gem 'puppet', ENV.key?('PUPPET_VERSION') ? "~> #{ENV['PUPPET_VERSION']}" : '~> 6.0'
-if RUBY_VERSION < '2.1'
-  gem 'puppet-strings', '< 2.0.0'
-else
-  gem 'puppet-strings'
-end
+gem 'facter', '>= 3.0'
+
+gem 'puppet-strings'
 gem 'rake'
-gem 'rdoc', '< 6' if RUBY_VERSION < '2.2'
 
 group :test do
   gem 'rspec'
   gem 'rubocop', '~> 0.50.0'
 end
 
 group :development do
-  # Needed to pin dependencies
+  # Dependencies for rake pin_modules
   gem 'puppet_forge'
-  if RUBY_VERSION < '2.1'
-    gem 'semverse', '< 2'
-  elsif RUBY_VERSION < '2.2'
-    gem 'semverse', '< 3'
-  else
-    gem 'semverse'
-  end
+  gem 'semverse'
 end