Fixes #38228 - Add Hammer CLI for foreman_bootdisk #1009
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
error reported by GHA: Does that mean my code is broken, GHA are broken (unlikely), or that I should push a DROP ME commit that references my branch in puppet-foreman? |
|
It means you started CI before the puppet-foreman PR was merged. By now it's merged so restarting CI should be sufficient |
Refs GitHub PR 1213 in puppet-foreman Based on 73df3c2
maximiliankolb
force-pushed
the
38228_bootdisk_cli
branch
from
cf6673e to
b4b1271
Compare
|
Restarted GHA by force push. |
|
@ekohl GHA is now green. Kindly asking for your review/ACK/merge. |
ekohl
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on 73df3c2
https://projects.theforeman.org/issues/38228
Tested locally by cherry-picking on Foreman 3.11; compared the stdout of foreman-installer, dnf, and hammer which all looked sane to me.
Refs theforeman/puppet-foreman#1213
Tests require a change in Puppetfile to reference the proper branch for puppet-foreman