Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jquery-ui-rails package to katello #11416

Merged
merged 1 commit into from
Dec 19, 2024
Merged

add jquery-ui-rails package to katello #11416

merged 1 commit into from
Dec 19, 2024

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Oct 31, 2024 •
edited
Loading

split from #11004

@MariaAga MariaAga requested a review from a team as a code owner October 31, 2024 16:14
adamruzicka
adamruzicka approved these changes Oct 31, 2024
View reviewed changes
Copy link

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with this we should be able to break the cyclical dependency between the three (now four) opened PRs.

@MariaAga MariaAga mentioned this pull request Oct 31, 2024
Closed
@adamruzicka
Copy link

Needs a rebase

@MariaAga MariaAga force-pushed the add-jquery-ui-katello branch from a1a2163 to f530f2d Compare November 4, 2024 10:35
@MariaAga
Copy link
Member Author

MariaAga commented Nov 4, 2024

Rebased

@adamruzicka
Copy link

And once more I'm afraid

@MariaAga MariaAga force-pushed the add-jquery-ui-katello branch 2 times, most recently from c5d55a3 to 272c8bc Compare November 12, 2024 12:04
@MariaAga
Copy link
Member Author

@theforeman/packaging

@adamruzicka
Copy link

[test rpm-copr]

@adamruzicka
Copy link

Sigh, if I'm reading it right, rebasing once more should make the current build failures go away.

@MariaAga
Copy link
Member Author

unfourtunetly Current branch add-jquery-ui-katello is up to date.

@adamruzicka
Copy link

[test rpm-copr]

@MariaAga MariaAga force-pushed the add-jquery-ui-katello branch from 272c8bc to c49732f Compare December 2, 2024 12:26
@MariaAga
Copy link
Member Author

MariaAga commented Dec 2, 2024

Rebased again
@theforeman/packaging Does this need anything else?

@MariaAga MariaAga force-pushed the add-jquery-ui-katello branch from c49732f to 36fcd52 Compare December 17, 2024 13:23
@ekohl ekohl merged commit 17b016b into theforeman:rpm/develop Dec 19, 2024
3 checks passed
@MariaAga MariaAga mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
RPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MariaAga @adamruzicka @ekohl