Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37702 - Registration - Find methods for taxonomies #10259

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

stejskalleos
Copy link
Contributor

@stejskalleos stejskalleos commented Jul 31, 2024

Load taxonomies in the finding methods to allow
easy extension from the plugins.

See Katello/katello#11094

@stejskalleos
Copy link
Contributor Author

For documentation, the order of assigning taxonomies:

  1. from the taxonomy_id parameter (if present)
  2. User's default
  3. First item from the user's assigned orgs/loc

For Katello, it's different, see Katello/katello#11094 (comment)

@stejskalleos
Copy link
Contributor Author

@ShimShtein updated along with the Katello PR

Copy link
Member

@ShimShtein ShimShtein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are spending time on this code, let's make it a bit more robust, especially if you want to extend it.

Capture taxonomies in the finding methods to allow for easy extension from the plugins.
@stejskalleos
Copy link
Contributor Author

@ShimShtein PR updated + added tests. Now exposed methods are default_organization and default_location. I haven't updated the Katello PR yet; I'll wait for the approved review here first.

@evgeni evgeni closed this Aug 15, 2024
@evgeni evgeni reopened this Aug 15, 2024
@ShimShtein ShimShtein merged commit 992ce98 into theforeman:develop Aug 15, 2024
101 checks passed
@Lennonka
Copy link

Lennonka commented Aug 15, 2024

For documentation, the order of assigning taxonomies:

  1. from the taxonomy_id parameter (if present)
  2. User's default
  3. First item from the user's assigned orgs/loc

For Katello, it's different, see Katello/katello#11094 (comment)

@stejskalleos If you've changed the implementation then this ^^ behavior is also different than described previously?
The taxonomy_id parameter is a host parameter? What kind of parameter is it and where does the parameter come from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants