-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37702 - Registration - Find methods for taxonomies #10259
Conversation
For documentation, the order of assigning taxonomies:
For Katello, it's different, see Katello/katello#11094 (comment) |
faaee8d
to
f97a00a
Compare
@ShimShtein updated along with the Katello PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are spending time on this code, let's make it a bit more robust, especially if you want to extend it.
Capture taxonomies in the finding methods to allow for easy extension from the plugins.
f97a00a
to
ed544f9
Compare
@ShimShtein PR updated + added tests. Now exposed methods are |
@stejskalleos If you've changed the implementation then this ^^ behavior is also different than described previously? |
Load taxonomies in the finding methods to allow
easy extension from the plugins.
See Katello/katello#11094