Refs #37733 - Improve formatting of the new Host Ansible Role audit #10277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Aug 16, 2024
Comment on lines
+46
to
+47
| when 'Host Ansible Role' | ||
| audit.associated_name + " / " + id_to_label("ansible_role_id", audit.audited_changes["ansible_role_id"], audit: audit) |
There was a problem hiding this comment.
This is not exactly fortunate considering ansible roles are something that lives in a plugin. Let's talk about it next time we see each other
|
Closing as solution inside the plugin repo was found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the new host ansible role audits.
From:
To:
Requires theforeman/foreman_ansible#729 to be merged.