Refs #36547 - explicitly stringify major/minor for Ubuntu

[evgeni]

We stringify these anyway on save, but here it's also used for
searching, and that fails to find the existing OS when searching with
minor=nil.

When the existing OS is not found, a new one is created, but that fails
to save as the name/major/minor combination already exists and that
breaks fact uploads.

Fixes: d690fa7

[evgeni]

cc @sbernhard @goarsna

[sbernhard]

Make sense. Thank you!

[ekohl]

👍 but please make it Refs #36547 since that hasn't been released yet.

[ekohl]

This is an interesting failure that looks unrelated:

 [MinitestRetry] retry 'test_0002_Apipie DSL docs URL should be successful' count: 1,  msg: FrozenError: can't modify frozen String: ""
    lib/foreman/middleware/libvirt_connection_cleaner.rb:9:in `call'
    lib/foreman/middleware/telemetry.rb:10:in `call'
    lib/foreman/middleware/logging_context_session.rb:22:in `call'
    lib/foreman/middleware/logging_context_request.rb:11:in `call'
    test/integration/apipie_test.rb:10:in `block in <class:ApipieIntegrationTest>'

Sadly it happens somewhere and middleware is not providing a useful traceback.

@ofedoren have you seen this before?

[goarsna]

Thanks for fixing this, @evgeni

[ofedoren]

This is an interesting failure that looks unrelated:

 [MinitestRetry] retry 'test_0002_Apipie DSL docs URL should be successful' count: 1,  msg: FrozenError: can't modify frozen String: ""
    lib/foreman/middleware/libvirt_connection_cleaner.rb:9:in `call'
    lib/foreman/middleware/telemetry.rb:10:in `call'
    lib/foreman/middleware/logging_context_session.rb:22:in `call'
    lib/foreman/middleware/logging_context_request.rb:11:in `call'
    test/integration/apipie_test.rb:10:in `block in <class:ApipieIntegrationTest>'

Sadly it happens somewhere and middleware is not providing a useful traceback.

@ofedoren have you seen this before?

I'm afraid I have not :/