Fixes #36230 - Puppet removal parameter to installer is no longer used #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've a proposed a test to ensure this over in bats: theforeman/forklift#1664 |
ehelms
force-pushed
the
update-disable-puppet
branch
from
92f4a2c to
7783d04
Compare
ekohl
reviewed
Mar 27, 2023
I would assume if you cherry pick this back to an older release you are doing so with the intent to provide this functionality to that older release. But since those checks exist, I can update them. They are a hold over from the previous release model foreman_maintain was used in with Satellite. |
ehelms
force-pushed
the
update-disable-puppet
branch
from
7783d04 to
9049786
Compare
ehelms
force-pushed
the
update-disable-puppet
branch
from
9049786 to
8ee29a4
Compare
ekohl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.