Fix some RuboCop rules (#185)

* Fix Style/SafeNavigation cop * Fix Rails/FindEach cop
theforeman · Jul 10, 2024 · 55755bf · 55755bf
1 parent 1cd6b99
commit 55755bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/services/foreman_templates/parse_result.rb b/app/services/foreman_templates/parse_result.rb
@@ -15,7 +15,7 @@ def to_h(verbose = false)
         :imported => @imported,
         :additional_errors => @additional_errors,
         :additional_info => @additional_info,
-        :exception => @exception ? @exception.message : nil,
+        :exception => @exception&.message,
         :validation_errors => errors.to_h,
         :file => @template_file,
         :type => @template.present? ? @template.class.name.underscore : nil
@@ -27,7 +27,7 @@ def to_h(verbose = false)
     end
 
     def errors
-      @template ? @template.errors : nil
+      @template&.errors
     end
 
     def corrupted_metadata

diff --git a/app/services/foreman_templates/template_importer.rb b/app/services/foreman_templates/template_importer.rb
@@ -164,7 +164,7 @@ def auto_prefix(name)
 
     def purge!
       clause = "name #{@negate ? 'NOT ' : ''}LIKE ?"
-      ProvisioningTemplate.where(clause, "#{@prefix}%").each do |template|
+      ProvisioningTemplate.where(clause, "#{@prefix}%").find_each do |template|
         puts template if @verbose
         template.destroy
       end