Remove deploy via provider

[ehelms]

This includes commits that are in existing PRs, and is working towards this change with small incremental updates.

[ekohl]

Not a complete review, but one thing that jumped out.

[ehelms]

This includes #420 which I would like to have in first.

[ehelms]

Well, this is annoying, the acceptance tests come out differently on EL9 due to spacing:

      Failure/Error: its(:issuer) { should eq("C = US, ST = North Carolina, L = Raleigh, O = Katello, OU = SomeOrgUnit, CN = #{fqdn}") }
        
        expected: "C = US, ST = North Carolina, L = Raleigh, O = Katello, OU = SomeOrgUnit, CN = centos9-64.example.com"
             got: "C=US, ST=North Carolina, L=Raleigh, O=Katello, OU=SomeOrgUnit, CN=centos9-64.example.com"

[evgeni]

I could swear we have this issue somewhere else too and somehow made it work.

Katello certs tools?

[ehelms]

I could swear we have this issue somewhere else too and somehow made it work.

Katello certs tools?

I couldn't find anything. One option is to update serverspec project to use a standardized output when printing the subject or issuer with -nameopt oneline. Means we will have to wait and hope for a release.

Another option is to create our own matcher instead of eq to match and not care about the output style and rather care about the content.

Third option is to use command and have contorl over it:

describe command('openssl x509 -noout -text -in <cert> -nameopt oneline') do
  its(:stdout) {}
end

A fourth option is to carry a patch here in this repo to these two functions https://github.com/mizzy/serverspec/blob/master/lib/serverspec/type/x509_certificate.rb#L9-L15

[evgeni]

Would its(:issuer).gsub(' ', '').to eq("blah") work?

[ehelms]

Would its(:issuer).gsub(' ', '').to eq("blah") work?

This is the winner https://github.com/theforeman/puppet-certs/blob/master/spec/support/acceptance/matchers/match_without_whitespace.rb

[ehelms]

This is should fix it up #443

[ehelms]

This is rebased and tests updated. This does two things effectively:

• Removes the ability to deploy certificates through the provider that generates them
• Removes creation of the RPMs from katello-certs-tool that are no longer used for any part of the process

I think further re-factoring can come after this. My goal is to first remove the RPM aspect as cleanly as I can.

[evgeni]

Puppet providers are really not my domain, but I posted a few comments ;-)

[ehelms]

Puppet providers are really not my domain, but I posted a few comments ;-)

Appreciated - they helped me clean the code up.