Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset all possible dash/underscore combinations of REMOTE_USER #1181

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Unset all possible dash/underscore combinations of REMOTE_USER #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions manifests/config/apache.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,23 @@
String[1] $keycloak_app_name = 'foreman-openidc',
String[1] $keycloak_realm = 'ssl-realm',
Array[String[1]] $request_headers_to_unset = [
'REMOTE-USER',
'REMOTE_USER',
'REMOTE-USER-EMAIL',
'REMOTE-USER_EMAIL',
'REMOTE_USER-EMAIL',
'REMOTE_USER_EMAIL',
'REMOTE-USER-FIRSTNAME',
'REMOTE-USER_FIRSTNAME',
'REMOTE_USER-FIRSTNAME',
'REMOTE_USER_FIRSTNAME',
'REMOTE-USER-LASTNAME',
'REMOTE-USER_LASTNAME',
'REMOTE_USER-LASTNAME',
'REMOTE_USER_LASTNAME',
'REMOTE-USER-GROUPS',
'REMOTE-USER_GROUPS',
'REMOTE_USER-GROUPS',
'REMOTE_USER_GROUPS',
],
) {
Expand Down
26 changes: 26 additions & 0 deletions spec/classes/foreman_config_apache_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,23 @@
'set SSL_CLIENT_S_DN ""',
'set SSL_CLIENT_CERT ""',
'set SSL_CLIENT_VERIFY ""',
'unset REMOTE-USER',
'unset REMOTE_USER',
'unset REMOTE-USER-EMAIL',
'unset REMOTE-USER_EMAIL',
'unset REMOTE_USER-EMAIL',
'unset REMOTE_USER_EMAIL',
'unset REMOTE-USER-FIRSTNAME',
'unset REMOTE-USER_FIRSTNAME',
'unset REMOTE_USER-FIRSTNAME',
'unset REMOTE_USER_FIRSTNAME',
'unset REMOTE-USER-LASTNAME',
'unset REMOTE-USER_LASTNAME',
'unset REMOTE_USER-LASTNAME',
'unset REMOTE_USER_LASTNAME',
'unset REMOTE-USER-GROUPS',
'unset REMOTE-USER_GROUPS',
'unset REMOTE_USER-GROUPS',
'unset REMOTE_USER_GROUPS'
])
.with_proxy_pass(
Expand Down Expand Up @@ -192,10 +205,23 @@ class { 'apache':
'set SSL_CLIENT_S_DN "%{SSL_CLIENT_S_DN}s"',
'set SSL_CLIENT_CERT "%{SSL_CLIENT_CERT}s"',
'set SSL_CLIENT_VERIFY "%{SSL_CLIENT_VERIFY}s"',
'unset REMOTE-USER',
'unset REMOTE_USER',
'unset REMOTE-USER-EMAIL',
'unset REMOTE-USER_EMAIL',
'unset REMOTE_USER-EMAIL',
'unset REMOTE_USER_EMAIL',
'unset REMOTE-USER-FIRSTNAME',
'unset REMOTE-USER_FIRSTNAME',
'unset REMOTE_USER-FIRSTNAME',
'unset REMOTE_USER_FIRSTNAME',
'unset REMOTE-USER-LASTNAME',
'unset REMOTE-USER_LASTNAME',
'unset REMOTE_USER-LASTNAME',
'unset REMOTE_USER_LASTNAME',
'unset REMOTE-USER-GROUPS',
'unset REMOTE-USER_GROUPS',
'unset REMOTE_USER-GROUPS',
'unset REMOTE_USER_GROUPS'
])
.with_ssl_proxyengine(true)
Expand Down
Loading