Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running on Puppet Enterprise Primary #848

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

bastelfreak
Copy link
Member

This enables user to run foreman-proxy on a Puppet Enterprise primary.

@bastelfreak
Copy link
Member Author

Draft because I'm still testing

manifests/init.pp Outdated Show resolved Hide resolved
This enables user to run foreman-proxy on a Puppet Enterprise primary.
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the fact is from the Agent, so if people run OSS Agent on PE Server, this will still break, but I really hope nobody is that crazy? ;-)

@evgeni evgeni changed the title Add support for PE Add support for running on Puppet Enterpise Primary Nov 13, 2024
@bastelfreak
Copy link
Member Author

So after a very ugly debugging session:

  • is_pe exists in stdlib and in puppet enterprise. in PE it's broken and always returns false (lol)
  • is_pe from stdlib is true when pe_version is not empty
  • pe_version gets the same value as pe_build
  • pe_build gets the value from reading /opt/puppetlabs/server/pe_version
  • /opt/puppetlabs/server/pe_version is provided by pe-puppet-enterprise-release.rpm
  • the puppet-agent.rpm on PE and FOSS is identical
  • This patch works on every PE infra node, no matter where the agent is coming from

@ekohl ekohl changed the title Add support for running on Puppet Enterpise Primary Add support for running on Puppet Enterprise Primary Nov 20, 2024
@ekohl ekohl merged commit 6645a72 into theforeman:master Nov 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants