Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #32891 - Optionally enable new Pulpcore tasking system #371

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

wbclark
Copy link
Contributor

@wbclark wbclark commented Jun 29, 2021

@ehelms
Copy link
Member

ehelms commented Jun 29, 2021

We discussed today that we should enable the new tasking as the default since it's the future and solves a lot of the problems. We didn't discuss at what level we should set the default:

  • pulpcore
  • foreman_proxy_content
  • installer

At a minimum, I think the last two, and for consistency, might as well be all three.

@wbclark
Copy link
Contributor Author

wbclark commented Jun 29, 2021

We discussed today that we should enable the new tasking as the default since it's the future and solves a lot of the problems. We didn't discuss at what level we should set the default:

* pulpcore

* foreman_proxy_content

* installer

At a minimum, I think the last two, and for consistency, might as well be all three.

Agree it should be the default. Originally when I was pursuing backwards compatibility, it made sense to me to take an incremental approach with default initially off and then change the default over to on.

I think given the timeline, and the agreement that backwards compatibility isn't necessary, then I can go ahead and make the change over in all places.

@wbclark wbclark force-pushed the 32891_new_pulpcore_tasking branch from 52e9cf0 to abdc9cf Compare June 29, 2021 16:45
@ehelms
Copy link
Member

ehelms commented Jul 8, 2021

Since #372 contains the metadata version update, I'll merge this one after it goes in.

@ehelms ehelms merged commit baa0e9c into theforeman:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants