Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for CI #96

Merged
merged 6 commits into from
Nov 28, 2024
+31 −21
Merged

Use GitHub Actions for CI #96

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4abd2a3
Use the GPL-3.0-only license tag instead of deprecated GPL-3.0
ekohl Nov 11, 2024
46c7b22
Raise minimum Ruby version to 2.7
ekohl Nov 11, 2024
79bf2a9
Remove unused net-ssh runtime dependency
ekohl Nov 11, 2024
f07cd34
Remove redundant development dependencies
ekohl Nov 11, 2024
cbc0ce9
Use GitHub Actions for CI
ekohl Nov 11, 2024
4f20065
Correct globbing code handling in tests
ekohl Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: CI

on: pull_request

concurrency:
group: ${{ github.ref_name }}-${{ github.workflow }}
cancel-in-progress: true

jobs:
test:
name: Tests
uses: theforeman/actions/.github/workflows/smart_proxy_plugin.yml@v0
3 changes: 1 addition & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ source 'https://rubygems.org'
gemspec

group :development do
gem 'smart_proxy', git: 'https://github.com/theforeman/smart-proxy',
branch: 'develop'
gem 'smart_proxy', github: 'theforeman/smart-proxy', branch: ENV['SMART_PROXY_BRANCH']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theforeman/smart_proxy_plugin_template@71bd2b6 we used ENV.fetch(…, 'develop') -- or will branch default to the default branch if it's nil?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on Fedora without specifying it and that works. The Bundler docs haven't been updated, but looks like this is a Rubygem 2.3 feature: rubygems/rubygems@6e032a9

Would you prefer to support < 2.3?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what < 2.3 means for rubygems 🙈
But also, we should be consistent between here and the docs in the actions repo and the template ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think we're not ready for that and I'll change it back to being explicit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking!

#gem 'smart_proxy', path: '../smart-proxy'
gem 'pry'
gem 'pry-byebug'
Expand Down
10 changes: 2 additions & 8 deletions smart_proxy_ansible.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,10 @@ Gem::Specification.new do |gem|
gem.extra_rdoc_files = ['README.md', 'LICENSE']
gem.test_files = gem.files.grep(%r{^(test|spec|features)/})
gem.require_paths = ['lib']
gem.license = 'GPL-3.0'
gem.required_ruby_version = '>= 2.5'
gem.license = 'GPL-3.0-only'
gem.required_ruby_version = '>= 2.7'

gem.add_development_dependency 'rake', '~> 13.0'
gem.add_development_dependency('mocha', '~> 1')
gem.add_development_dependency('webmock', '~> 3')
gem.add_development_dependency('rack-test', '~> 0')
gem.add_development_dependency('logger')
gem.add_development_dependency('smart_proxy')
gem.add_runtime_dependency('net-ssh')
gem.add_runtime_dependency('smart_proxy_dynflow', '~> 0.8')
gem.add_runtime_dependency('smart_proxy_remote_execution_ssh', '~> 0.4')
end
Loading