added base64 decoding of username and password #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Can you please fix the indention, like in https://github.com/theforeman/smart_proxy_salt/pull/91/files#diff-7837e29df8da6b091fd69027c5e8a287cc646a6c06332cf9f9474821e92e3b36L56 |
|
Im not sure the original file was correctly formatted. I have ran this through python linting, it should now be following pythons suggested formatting. This is following PEP 8, but I can remove the empty lines between comments and def's if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is when using username/password that the base64.b64encode function requires a bytes-like object, but it's receiving a string instead.
We can fix this by encoding the username and password string before passing it to base64.b64encode.