Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Redmine sections of Foreman's release procedure #433

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Enhance Redmine sections of Foreman's release procedure #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion procedure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ procedures = {
full_version: full_version, # 1.20.0-rc1
version: version, # 1.20.0
short_version_minus_two: "#{major}.#{minor.to_i - 2}",
short_version_minus_five: "#{major}.#{minor.to_i - 5}"
short_version_minus_five: "#{major}.#{minor.to_i - 5}",
next_patch_version: "#{major}.#{minor}.#{patch.to_i + 1}",
)
end
opts.on('--foreman-version [X.Y]', /^\d+\.\d+$/, 'Foreman version, for Katello') do |foreman_version|
Expand Down
9 changes: 6 additions & 3 deletions procedures/foreman/release.md.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

## Release Owner

- [ ] Remove/change target version field for any open Redmine tickets assigned to the release still (next minor, unset it or reject)
- [ ] Ensure that code in git matches issues fixed in <%= full_version %> in redmine. [issues](https://github.com/theforeman/theforeman-rel-eng/blob/master/issues) can be used to generate a comparison between the two.
- [ ] Make sure any release blocking issues are resolved and remove/change target version field for any open Redmine tickets assigned to the release still (next minor, unset it or reject). Look for the `<%= version %> release TODO` saved query on [Foreman's issues](https://projects.theforeman.org/projects/foreman/issues).
- [ ] Ensure that code in git matches issues fixed in <%= full_version %> in Redmine. Use the `<%= version %> release DONE` saved query on [Foreman's issues](https://projects.theforeman.org/projects/foreman/issues). [issues](https://github.com/theforeman/theforeman-rel-eng/blob/master/issues) can be used to generate a comparison between the two.
- [ ] Check for open pull requests in [Foreman](https://github.com/theforeman/foreman/pulls?q=is%3Apr+is%3Aopen+branch%3A<%= short_version %>-stable), [smart-proxy](https://github.com/theforeman/smart-proxy/pulls?q=is%3Apr+is%3Aopen+branch%3A<%= short_version %>-stable), [foreman-installer](https://github.com/theforeman/foreman-installer/pulls?q=is%3Apr+is%3Aopen+branch%3A<%= short_version %>-stable) and [foreman-selinux](https://github.com/theforeman/foreman-selinux/pulls?q=is%3Apr+is%3Aopen+branch%3A<%= short_version %>-stable)

# Tagging a release: <%= target_date %>
Expand All @@ -38,7 +38,7 @@
- [ ] Run the Jenkins [Tarballs Release](https://ci.theforeman.org/job/tarballs-release/) using <%= rel_eng_script('release_tarballs') %> to create tarballs
<% unless is_rc -%>
- [ ] Change Redmine version <%= full_version %> state to Closed using <%= rel_eng_script('close_redmine_version') %>
- [ ] Add a new [Redmine version](https://projects.theforeman.org/projects/foreman/settings/versions) for the next minor, unless the series is EOL. Be sure the version is set to sharing with subprojects.
- [ ] Add a new [Redmine version](https://projects.theforeman.org/projects/foreman/settings/versions) for <%= next_patch_version %><%= ', unless the series is EOL' unless is_first_ga %>. Be sure the version is set to sharing with subprojects.
<% end -%>

## Release Engineer
Expand Down Expand Up @@ -150,3 +150,6 @@ Note: If for some reason there was an issue with the tarballs that required uplo
- [ ] Create an issue in [foreman-infra](https://github.com/theforeman/foreman-infra/issues) to archive old Debian releases (keeping <%= short_version_minus_five %> and newer)
<% end -%>
- [ ] Release pipeline will trigger [foreman-plugins-<%= short_version %>-deb-test-pipeline](https://ci.theforeman.org/job/foreman-plugins-<%= short_version %>-deb-test-pipeline/) and [foreman-plugins-<%= short_version %>-rpm-test-pipeline](https://ci.theforeman.org/job/foreman-plugins-<%= short_version %>-rpm-test-pipeline/). These don't block releases but can be used to understand known issues around plugin compatibility with Foreman <%= short_version %>.
<% unless is_rc -%>
- [ ] <%= 'Unless the series is EOL: ' unless is_first_ga %>Prepare <%= next_patch_version %> by updating the `<%= version %> release TODO` and `<%= version %> release DONE` saved queries on [Foreman's issues](https://projects.theforeman.org/projects/foreman/issues). Be sure to update both the name and individual filters.
<% end -%>
Loading